fix(a11y): add aria-label to data table filter inputs#10398
Open
akinshaywai wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix(a11y): add aria-label to data table filter inputs#10398akinshaywai wants to merge 1 commit intoshadcn-ui:mainfrom
akinshaywai wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
Closes shadcn-ui#10397 Added aria-label attribute to the filter Input in the Radix data table demo. The Input previously used placeholder text as its only accessible name, which is a WCAG 2.1 Level A violation (SC 4.1.2). Screen readers now announce "Filter emails" instead of just "edit text".
Contributor
|
@akinshaywai is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10397
Description
Added
aria-labelattribute to the filter<Input>in the Data Table demo example. The input previously relied onplaceholdertext as its only accessible name, which is not a valid accessible name per WCAG 2.1.Changes
aria-label="Filter emails"to the filter Input inapps/v4/examples/radix/data-table-demo.tsxImpact
Screen readers now announce "Filter emails" instead of just "edit text" or reading the placeholder with no label context.
This is a WCAG 2.1 Level A fix under Success Criterion 4.1.2 (Name, Role, Value).
Why this matters
Since developers copy these examples directly into their projects, missing accessible labels propagate to production applications. This fix ensures developers start with accessible patterns by default.